-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: events/eventtarget throws #33782
Labels
benchmark
Issues and PRs related to the benchmark subsystem.
events
Issues and PRs related to the events subsystem / EventEmitter.
eventtarget
Issues and PRs related to the EventTarget implementation.
Comments
mscdex
added
events
Issues and PRs related to the events subsystem / EventEmitter.
benchmark
Issues and PRs related to the benchmark subsystem.
labels
Jun 7, 2020
I think this is already fixed by #33624 which just needs to land (along with the other PRs) |
jasnell
added
the
eventtarget
Issues and PRs related to the EventTarget implementation.
label
Jun 19, 2020
Can we temporarily remove this benchmark in the meantime? I checked and the linked PR is evidently not enough to fix the error with the benchmark. In particular this issue is currently preventing the gathering of all |
mscdex
added a commit
to mscdex/io.js
that referenced
this issue
Jun 21, 2020
jasnell
pushed a commit
to jasnell/node
that referenced
this issue
Jun 22, 2020
codebytere
pushed a commit
that referenced
this issue
Jun 27, 2020
Fixes: #33782 PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this issue
Jun 30, 2020
Fixes: #33782 PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
benchmark
Issues and PRs related to the benchmark subsystem.
events
Issues and PRs related to the events subsystem / EventEmitter.
eventtarget
Issues and PRs related to the EventTarget implementation.
The events/eventtarget.js benchmark fails every time with:
/cc @jasnell
The text was updated successfully, but these errors were encountered: