Assertion error starting from v14.0.0

[ghost]

Our code:

const assert = require('assert');

module.exports = new Proxy({}, {
  getPrototypeOf(){
    assert.fail();
  }
});

We want to export a proxified object and explicitly ensure that user code will not trigger certain traps. Works fine in v12.x. Throws assertion error in v14.x, but we did not call getPrototypeOf.

We bisected to d7452b7. Throws error even with --no-warnings.

Please Node.js team, can you fix this? Thanks.

[rickyes]

node/lib/internal/modules/cjs/loader.js

Lines 945 to 950 in 94e5b5c

	} else if (module.exports &&
	ObjectGetPrototypeOf(module.exports) ===
	CircularRequirePrototypeWarningProxy) {
	ObjectSetPrototypeOf(module.exports, PublicObjectPrototype);
	}
	}

It looks like getPrototypeOf is called after successful module loading.

[rickyes]

Maybe we could use --no-warnings without checking CircularRequirePrototypeWarningProxy.

/cc @addaleax