Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module.path exists but is not documented #33270

Closed
ha6000 opened this issue May 6, 2020 · 6 comments
Closed

module.path exists but is not documented #33270

ha6000 opened this issue May 6, 2020 · 6 comments
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.

Comments

@ha6000
Copy link

ha6000 commented May 6, 2020

The module object does not contain the path property.
@Trott

This comment has been minimized.

Sign in to view
@Trott Trott closed this as completed May 6, 2020
@Trott

This comment has been minimized.

Sign in to view
@ha6000
Copy link
Author

ha6000 commented May 6, 2020

Im pretty sure it exist

@Trott
Copy link
Member

Trott commented May 6, 2020

Im pretty sure it exist

Yes, it does.

So the bug is that it is not documented?

@Trott Trott reopened this May 6, 2020
@Trott Trott changed the title path property not in Module module.path exists but is not documented May 6, 2020
@Trott Trott transferred this issue from nodejs/nodejs.org May 6, 2020
@Trott Trott added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels May 6, 2020
@aduh95
Copy link
Contributor

aduh95 commented May 9, 2020

Added on d004313. Should it be documented or rather hidden behind a Symbol?

CC @BridgeAR

aduh95 added a commit to aduh95/node that referenced this issue May 9, 2020
@aduh95
doc: document module.path
997f01b 
Refs: nodejs#26970
Fixes: nodejs#33270
@aduh95 aduh95 mentioned this issue May 9, 2020
Closed
3 tasks
@domleonard
Copy link

domleonard commented May 19, 2020 •
edited
Loading

To clarify users' experience of the issue: https://nodejs.org/docs/latest/api/modules.html#modules_the_module_object does not contain a heading for module.path, and there is no link for #modules_module_path in contents at the top of the page.

codebytere pushed a commit that referenced this issue May 21, 2020
@aduh95 @codebytere
doc: document module.path
f52b56c 
Refs: #26970
Fixes: #33270

PR-URL: #33323
Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this issue Jun 7, 2020
@aduh95 @codebytere
doc: document module.path
6dbcd0a 
Refs: #26970
Fixes: #33270

PR-URL: #33323
Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this issue Jun 9, 2020
@aduh95 @codebytere
doc: document module.path
98a7026 
Refs: #26970
Fixes: #33270

PR-URL: #33323
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: document module.path aduh95/node
4 participants
@Trott @aduh95 @domleonard @ha6000