-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: make rmdir() emfileWait handle ENFILE #30482
Labels
fs
Issues and PRs related to the fs subsystem / file system.
good first issue
Issues that are suitable for first-time contributors.
Comments
bnoordhuis
added
fs
Issues and PRs related to the fs subsystem / file system.
good first issue
Issues that are suitable for first-time contributors.
labels
Nov 14, 2019
I would like to work on this issue |
@thangktran Go for it :) |
thangktran
added a commit
to thangktran/node
that referenced
this issue
Nov 15, 2019
4 tasks
addaleax
pushed a commit
that referenced
this issue
Nov 30, 2019
Co-authored-by: Thang Tran <[email protected]> Fixes: #30482 Refs: #30499 Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this issue
Jan 13, 2020
Co-authored-by: Thang Tran <[email protected]> Fixes: #30482 Refs: #30499 Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this issue
Feb 6, 2020
Co-authored-by: Thang Tran <[email protected]> Fixes: #30482 Refs: #30499 Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fs
Issues and PRs related to the fs subsystem / file system.
good first issue
Issues that are suitable for first-time contributors.
EMFILE
: current process is out of file descriptorsENFILE
: system is out of file descriptorsThe
fs.rmdir()
logic inlib/internal/fs/rimraf.js
currently handles the former but not the latter:node/lib/internal/fs/rimraf.js
Lines 43 to 44 in ed40123
Both are (hopefully) transient errors though and should be handled identically.
Since
ENFILE
is difficult to test for, I think it's okay to omit a regression test.The text was updated successfully, but these errors were encountered: