Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: keyObject.export() crashes on C++ assertion with ed25519 key #26316

Closed
mscdex opened this issue Feb 26, 2019 · 1 comment
Closed

crypto: keyObject.export() crashes on C++ assertion with ed25519 key #26316

mscdex opened this issue Feb 26, 2019 · 1 comment
Labels
crypto Issues and PRs related to the crypto subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Feb 26, 2019

  • Version: master
  • Platform: Linux
  • Subsystem: crypto
> crypto.createPublicKey(`-----BEGIN PRIVATE KEY-----\nMC4CAQAwBQYDK2VwBCIEIHXLsXm1lsq5HtyqJwQyFmpfEluuf0KOqP6DqMgGxxDL\n-----END PRIVATE KEY-----`).export()
./node[26040]: ../src/node_crypto.cc:3466:v8::Local<v8::String> node::crypto::KeyObject::GetAsymmetricKeyType() const: Assertion `false' failed.
 1: 0x5635a08bb190 node::Abort() [./node]
 2: 0x5635a08bb22e  [./node]
 3: 0x5635a09c1315 node::crypto::KeyObject::GetAsymmetricKeyType(v8::FunctionCallbackInfo<v8::Value> const&) [./node]
 4: 0x5635a0b5491e  [./node]
 5: 0x5635a0b558e8 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [./node]
 6: 0x5635a1a51fee  [./node]
Aborted (core dumped)

Using crypto.createPrivateKey() with the same key fails in the same way when exporting.
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Feb 26, 2019
@mscdex
Copy link
Contributor Author

mscdex commented Feb 26, 2019

PR incoming

@mscdex mscdex mentioned this issue Feb 26, 2019
Merged
3 tasks
@panva panva mentioned this issue Mar 1, 2019
Closed
mscdex added a commit to mscdex/io.js that referenced this issue Mar 12, 2019
@mscdex
crypto: fix EdDSA support for KeyObject
247c14c 
PR-URL: nodejs#26319
Fixes: nodejs#26316
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
BridgeAR pushed a commit that referenced this issue Mar 13, 2019
@mscdex @BridgeAR
crypto: fix EdDSA support for KeyObject
71d0a8a 
PR-URL: #26319
Fixes: #26316
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
BridgeAR pushed a commit that referenced this issue Mar 14, 2019
@mscdex @BridgeAR
crypto: fix EdDSA support for KeyObject
cc0ffc5 
PR-URL: #26319
Fixes: #26316
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
targos pushed a commit that referenced this issue Mar 28, 2019
@mscdex @targos
crypto: fix EdDSA support for KeyObject
25c8145 
PR-URL: #26319
Fixes: #26316
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mscdex