Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm is not ready for Node 11 #23013

Closed
targos opened this issue Sep 22, 2018 · 2 comments
Closed

npm is not ready for Node 11 #23013

targos opened this issue Sep 22, 2018 · 2 comments
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.

Comments

@targos
Copy link
Member

targos commented Sep 22, 2018

Currently, npm uses the deprecated crypto.pseudoRandomBytes API through its unique-slug dependency.

There is already a PR to fix it: npm/unique-slug#6
@targos targos added this to the 11.0.0 milestone Sep 22, 2018
@addaleax
Copy link
Member

Given that the only reason for deprecating seems to be “reducing undocumented API surface”, we should also definitely consider reverting the deprecation. Aliases are cheap and come with very little maintenance overhead.

addaleax added a commit to addaleax/node that referenced this issue Sep 22, 2018
@addaleax
crypto: downgrade DEP0115 to --pending-deprecation only
c662e87 
Aliases are very cheap to maintain, so an unconditional runtime
deprecation that affects existing ecosystem code is not
a good idea. This commit turns the runtime deprecation into
a `--pending-deprecation` one.

Fixes: nodejs#23013
@addaleax addaleax mentioned this issue Sep 22, 2018
Closed
4 tasks
@tniessen
Copy link
Member

I contacted npm via twitter, their response was

I'm glad you asked about this. We can't guarantee that repo will be looked at in the near future.

So I'm in favor of downgrading the deprecation as well.

@targos targos mentioned this issue Sep 22, 2018
Open
@targos targos added the npm Issues and PRs related to the npm client dependency or the npm registry. label Sep 22, 2018
@Flarna Flarna mentioned this issue Nov 5, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crypto: downgrade DEP0115 to --pending-deprecation only addaleax/node
3 participants
@addaleax @targos @tniessen