Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: missing history entry for 10.10.0 in fs.readDir(Sync) #22777

Closed
ajafff opened this issue Sep 9, 2018 · 0 comments
Closed

docs: missing history entry for 10.10.0 in fs.readDir(Sync) #22777

ajafff opened this issue Sep 9, 2018 · 0 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@ajafff
Copy link
Contributor

ajafff commented Sep 9, 2018

https://nodejs.org/api/fs.html#fs_fs_readdirsync_path_options

The history doesn't contain an entry for the recently added withFileTypes option. This is the same for the sync and async API.
@addaleax addaleax added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Sep 9, 2018
@tiendq tiendq mentioned this issue Sep 10, 2018
Closed
2 tasks
@addaleax addaleax removed the good first issue Issues that are suitable for first-time contributors. label Sep 11, 2018
targos pushed a commit that referenced this issue Sep 14, 2018
@tiendq @targos
doc: add history for withFileTypes in fs.readdir[Sync]()
09ae073 
PR-URL: #22794
Fixes: #22777
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this issue Sep 19, 2018
@tiendq @targos
doc: add history for withFileTypes in fs.readdir[Sync]()
58d0833 
PR-URL: #22794
Fixes: #22777
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this issue Sep 20, 2018
@tiendq @targos
doc: add history for withFileTypes in fs.readdir[Sync]()
6786730 
PR-URL: #22794
Fixes: #22777
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@addaleax @ajafff