-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make http test suite run http2 compat #20868
Comments
I think it's worth exploring but it's going to be quite difficult to do, I think. Many of the http tests rely on internals that are very different in http2, even with the compat layer, and there are many tests that simply do not translate. |
DaAitch
added a commit
to wildoak/node
that referenced
this issue
May 26, 2018
Simple try refactoring `test/parallel/test-http-request-end.js` to run with `http` and `http2`. Refs: nodejs#20868
Close in favor of #29829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think in theory it should be possible to run the http2 compat code using the http tests. The main thing missing is a http2 compat replacement for
http.request
. If we have that I believe we could make all the http test run using http2 compat by monkey patchinghttp
?Is this something that would be worth looking into?
Right now we seem to have 2 test suites for testing almost the same things.
The text was updated successfully, but these errors were encountered: