Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: escaping object keys in util.inspect() #16979

Closed
vsemozhetbyt opened this issue Nov 13, 2017 · 2 comments
Closed

util: escaping object keys in util.inspect() #16979

vsemozhetbyt opened this issue Nov 13, 2017 · 2 comments
Labels
good first issue Issues that are suitable for first-time contributors. util Issues and PRs related to the built-in util module.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 13, 2017 •
edited
Loading

  • Version: v4–v10
  • Platform: Windows 7 x64
  • Subsystem: util
'use strict';

console.log({ '\\n': '\\n' });
{ '\n': '\\n' }

Is it OK that we escape values here, but do not escape keys?
@vsemozhetbyt vsemozhetbyt added the util Issues and PRs related to the built-in util module. label Nov 13, 2017
@addaleax
Copy link
Member

I think we should escape the keys, yes.

@addaleax addaleax added good first issue Issues that are suitable for first-time contributors. mentor-available labels Nov 13, 2017
@ah-yu ah-yu mentioned this issue Nov 13, 2017
Closed
4 tasks
@ah-yu
Copy link
Contributor

ah-yu commented Nov 13, 2017

Hi,I picked this one as my first contribution to node. Any guidance is more than appreciated

MylesBorins pushed a commit that referenced this issue Dec 12, 2017
@ah-yu @MylesBorins
util: escaping object keys in util.inspect()
a37eb32 
PR-URL: #16986
Fixes: #16979
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 20, 2018
@ah-yu @MylesBorins
util: escaping object keys in util.inspect()
0522243 
PR-URL: #16986
Fixes: #16979
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 28, 2018
@ah-yu @MylesBorins
util: escaping object keys in util.inspect()
986fd40 
PR-URL: #16986
Fixes: #16979
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 30, 2018
@ah-yu @MylesBorins
util: escaping object keys in util.inspect()
e0e0ef7 
PR-URL: #16986
Fixes: #16979
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@snyk-bot snyk-bot mentioned this issue Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 1, 2020
Open
@kissofire kissofire mentioned this issue Mar 7, 2021
Open
@meghasfdc meghasfdc mentioned this issue Mar 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util: escaping object keys in util.inspect()
3 participants
@addaleax @vsemozhetbyt @ah-yu