Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly docs missing #14930

Closed
vsemozhetbyt opened this issue Aug 18, 2017 · 9 comments
Closed

Nightly docs missing #14930

vsemozhetbyt opened this issue Aug 18, 2017 · 9 comments
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Aug 18, 2017 •
edited
Loading

Sorry, if this is a known issue or not an issue.

It seems the last full nightly docs are:

https://nodejs.org/download/nightly/v9.0.0-nightly201708155f31d54720/docs/api/

The next 3 have only JSON:

https://nodejs.org/download/nightly/v9.0.0-nightly20170816e9c0263696/docs/api/
https://nodejs.org/download/nightly/v9.0.0-nightly2017081760f2fa9a8b/docs/api/
https://nodejs.org/download/nightly/v9.0.0-nightly201708184d842e3d66/docs/api/
@vsemozhetbyt vsemozhetbyt added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Aug 18, 2017
@Trott Trott mentioned this issue Aug 19, 2017
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Aug 19, 2017

#13482 seems like a likely source of the issue.

@Trott Trott mentioned this issue Aug 19, 2017
Closed
2 tasks
@tniessen
Copy link
Member

This should have been fixed in #14932 (8850fd4). Feel free to reopen if the nightly docs are still missing tomorrow.

MylesBorins pushed a commit that referenced this issue Sep 10, 2017
@maclover7 @MylesBorins
build: allow proper generation of html docs
f1f1517 
`gen-doc` always calls `gen-json`, which means it's impossible to
generate html docs. Changed this to pass in the command the user wants
to run.

PR-URL: #14932
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 12, 2017
@maclover7 @MylesBorins
build: allow proper generation of html docs
8f3537f 
`gen-doc` always calls `gen-json`, which means it's impossible to
generate html docs. Changed this to pass in the command the user wants
to run.

PR-URL: #14932
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Sep 17, 2017 •
edited
Loading

It is happening again. The last nightly with docs folder:

https://nodejs.org/download/nightly/v9.0.0-nightly2017091061e9ba1271/

all the next ones lack docs:

https://nodejs.org/download/nightly/v9.0.0-nightly20170912a10856a7d3/
https://nodejs.org/download/nightly/v9.0.0-nightly20170913bf1ca8fb2e/
https://nodejs.org/download/nightly/v9.0.0-nightly201709141a0727d85e/
https://nodejs.org/download/nightly/v9.0.0-nightly20170915a5916107dd/
https://nodejs.org/download/nightly/v9.0.0-nightly20170916b0d3bec95c/

@vsemozhetbyt vsemozhetbyt reopened this Sep 17, 2017
@vsemozhetbyt
Copy link
Contributor Author

cc @nodejs/build

@maclover7 maclover7 mentioned this issue Sep 17, 2017
Closed
2 tasks
@maclover7
Copy link
Contributor

Opened #15447 to try and fix this

@vsemozhetbyt vsemozhetbyt mentioned this issue Sep 17, 2017
Closed
addaleax pushed a commit to ayojs/ayo that referenced this issue Sep 17, 2017
@maclover7 @addaleax
doc: do not begin yaml value with backtick
cf8e90f 
Will break YAML parsing!

See details in the PR.

PR-URL: nodejs/node#15447
Fixes: nodejs/node#14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 28, 2017
@maclover7 @MylesBorins
doc: do not begin yaml value with backtick
f4c8412 
Will break YAML parsing!

See details in the PR.

PR-URL: #15447
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 29, 2017
@maclover7 @MylesBorins
doc: do not begin yaml value with backtick
f56bbe3 
Will break YAML parsing!

See details in the PR.

PR-URL: #15447
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this issue Oct 3, 2017
@maclover7 @MylesBorins
doc: do not begin yaml value with backtick
e166bd7 
Will break YAML parsing!

See details in the PR.

PR-URL: #15447
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this issue Oct 3, 2017
@maclover7 @MylesBorins
doc: do not begin yaml value with backtick
d790fa1 
Will break YAML parsing!

See details in the PR.

PR-URL: #15447
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@vsemozhetbyt
Copy link
Contributor Author

Sigh. The same again. The last nightly with docs folder:

https://nodejs.org/download/nightly/v9.0.0-nightly20171001f9be5fe52a/

The next ones lack docs:

https://nodejs.org/download/nightly/v9.0.0-nightly201710027069e633ca/
https://nodejs.org/download/nightly/v9.0.0-nightly201710037cff6e80bf/
https://nodejs.org/download/nightly/v9.0.0-nightly20171004a3cd8ed168/

cc @nodejs/build

@vsemozhetbyt vsemozhetbyt reopened this Oct 5, 2017
@vsemozhetbyt
Copy link
Contributor Author

Possible cause (like #15447): #15680

We should make some safety device for this.

This was referenced Oct 5, 2017
Closed
Closed
@vsemozhetbyt
Copy link
Contributor Author

Fixed in 0c49038

@maclover7
Copy link
Contributor

Pending issue is nodejs/build#887, personally still think best solution here is to compile docs with each node-test-commit run.

MylesBorins pushed a commit that referenced this issue Oct 11, 2017
@maclover7 @MylesBorins
doc: do not begin yaml value with backtick
e5b5a03 
Will break YAML parsing!

See details in the PR.

PR-URL: #15447
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Trott @maclover7 @tniessen @vsemozhetbyt