Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

building for mips #1432

Closed
ghost opened this issue Apr 15, 2015 · 6 comments · Fixed by #1974
Closed

building for mips #1432

ghost opened this issue Apr 15, 2015 · 6 comments · Fixed by #1974
Labels
confirmed-bug Issues with confirmed bugs. v8 engine Issues and PRs related to the V8 dependency.

Comments

@ghost
Copy link

ghost commented Apr 15, 2015

Hi all!

I am referring to issue #1032. I am building io.js 1.7.1 for mips and get following error:

../deps/v8/src/base/logging.cc:9:23: fatal error: execinfo.h: No such file or directory

Applying following patch to v8 solved my problem:

https://codereview.chromium.org/1066573005/patch/1/10001

May I request to include the patch into the next version?

Many thanks for your work on io.js
@ghost ghost mentioned this issue Apr 15, 2015
Closed
@mscdex mscdex added confirmed-bug Issues with confirmed bugs. v8 engine Issues and PRs related to the V8 dependency. labels Apr 15, 2015
@rvagg
Copy link
Member

rvagg commented Apr 16, 2015

I'd be +1 on floating a patch for this, but only as a backport from what's in V8 and the status of this patch appears to be in question:


smcgruer 2015/04/13 16:41:25
I'm on the fence about reintroducing this, as it's not actually used anywhere in the code.
It's main purpose is to stop uClibc from pretending to be glibc, which could also be done
by changing the V8_LIBC_GLIBC check to:

#elif (defined(__GLIBC__) || defined(__GNU_LIBRARY__)) && !defined(__UCLIBC__)

@ghost
Copy link
Author

ghost commented Apr 16, 2015

looking at https://github.com/v8/v8-git-mirror/blob/master/include/ it was accepted in master
[edit]
here the commit: v8/v8@a684535
[/edit]

@ghost ghost mentioned this issue Apr 16, 2015
Closed
@jbergstroem
Copy link
Member

Seems to have landed in v8 4.4.x. How far is that from a stable release?

@bnoordhuis bnoordhuis mentioned this issue Jun 14, 2015
Merged
@bnoordhuis
Copy link
Member

I think we can just cherry-pick it, see #1974.

@jbergstroem
Copy link
Member

I'm nowhere close to a MIPS box but yeah, we're getting this sooner or later through V8.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Jun 14, 2015
@bnoordhuis
v8: cherry-pick uclibc build patch from upstream
4b4b176 
Original commit log follows:

    Restore V8_LIBC_UCLIBC as a libc option.

    As uClibc defines __GLIBC__ in an attempt to look like glibc,
    V8_LIBC_GLIBC was true for uClibc as well. Checking for uClibc
    before glibc fixes this and restores the correct behavior.

    Review URL: https://codereview.chromium.org/1066573005

Fixes: nodejs#1432
PR-URL: nodejs#1974
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@bnoordhuis
Copy link
Member

Fixed by 4b4b176. Thanks for the bug report.

@BenBaratte BenBaratte mentioned this issue Nov 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v8: cherry-pick uclibc build patch from upstream bnoordhuis/io.js
4 participants
@mscdex @jbergstroem @bnoordhuis @rvagg