-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failling to build LTS versions with ICU 59 #13022
Comments
/cc @srl295 |
Ref: bump ICU to 59.1, I'm not sure it was backported to Ref 2: Previous PR depends on #11753 |
That specific build error is probably easy to fix by adding a In general though, V8 only supports one ICU version at a time, and with the v4.x and v6.x release lines that is ICU 58. |
@bnoordhuis Thanks, this fixed it. Build fine, only 3 tests not passing:
The |
Currently testing on my server, this single line change seems to be enough. Should I expect something to break, and if so how to detect any breakage? |
The parallel/test-intl failure is probably related. As to breakage: it's an untested combination; bugs are possible. I think we'd be open to floating a patch to fix the build error, open a pull request if you want to purse that. I'll go ahead and close this out. |
Should I open PR against -staging branches or just v4.x/v6.x ones? |
The -staging ones. The -staging branches contain what is to be released, the non-staging ones what has been released. |
OK, thanks. |
I’ve opened #13040. I’ll open one for v6.x once I’ll have fixed this one enough for it to be accepted. |
* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: #13022 PR-URL: #13040 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: #13022 PR-URL: #13040 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: #13022 PR-URL: #13040 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: #13022 PR-URL: #13040 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: nodejs/node#13022 PR-URL: nodejs/node#13040 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@ArchangeGabriel I've just tried building 4.x with ICU 59 myself and also saw this failure for parallel/test-intl. It seems to be a bug in V8 (fixed in later versions) -- wonder if it's worth fixing: https://bugs.chromium.org/p/chromium/issues/detail?id=364374 |
late once again. Yes, as @MylesBorins commit says, the |
Previous ICUs should be supported as well, at this point. |
@Qantas94Heavy but, your assessment of the TZ part seems correct. |
* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: #13022 PR-URL: #13040 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: nodejs/node#13022 PR-URL: nodejs/node#13040 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
When trying to build either Argon or Boron with ICU 59.x, it fails with the following error:
I’m not sure how to fix this, and if other changes are required, but this is an issue for ArchLinux packages.
The text was updated successfully, but these errors were encountered: