-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: --without-ssl and --without-intl imply new limitation (no debugger) #12758
Comments
Marked regression since when node8 is built |
@addaleax correct me if I'm wrong but the |
@refack Yeah, I see where you’re coming from, but I wouldn’t say it is a regression. This is related to features we’re intentionally adding and removing, there’s just no way we can avoid any incompatibilities. |
could we build a proxy? |
I thought about it, and then again, since this is an unintended consequence of the @addaleax you are right in that this not an |
* To fix nodejs#12758, added an assertion that if `--without-ssl` or `--without-intl` are set, --without-debugger must also be explicitly set. * Added `--without-debugger` is an alias to `--without-inspector`, since we removed the old TCP `debug` protocol the V8 `inspect` protocol is the only debugger available. Hence disabling `inspector` means disabling any kind on JS debugger. Fixes: nodejs#12758
Doesn't sound like a bug to me. Lots of stuff disappears when SSL isn't built in (crypto, https, ...). Building without OpenSSL is a fringe build, for special purposes. |
This is a regression in the build behaviour, since it's a new consequence of a feature that disappears. |
@refack I don't really follow, sorry. Are you saying that Or are you saying that |
Yes. My proposed solution is to require the builder to additionally explicitly specify |
Apparently |
I don't see the regression. Losing the Debugger is obviously backwards incompatible/semver-major (and was treated as such). Also, forcing people to type two flags instead of one is an annoyance rather than being helpful. Unless you are saying that its possible to not have SSL, but to have the Inspector? You are decoupling that? If not, I'm not sure what problem is being solved here. |
I was hoping that's possible. And I'm looking into it, but that's a bigger issue.
IMHO building a new (even semver-major) version and finding out you lost a previously available (important) ability, without any warning, is worse. Another solution would be to emit a warning, but I fear it'll be drowned in all sort of script outputs. |
There was a fair amount of warning that the Debugger was going away. And since there is no way to opt-out of the new behaviour, talking about opt-in vs opt-out doesn't seem to apply. And failing to disable SSL when configuring explicitly |
Addressed by #12978 |
Is there any reason why |
@sparkleholic |
Since #12197 (i.e. node8) when
node
is built--without-ssl
or--without-intl
inspector is not available. As a consequence node is built with no debugger interface.configure
does not warn about this (new) consequence.Since in previous versions these switches did not remove all debugger interface, this is a regression in the build behaviour.
Ref: #12757
The text was updated successfully, but these errors were encountered: