Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--use-bundled-ca and --use-openssl-ca order #12083

Closed
jasnell opened this issue Mar 28, 2017 · 0 comments
Closed

--use-bundled-ca and --use-openssl-ca order #12083

jasnell opened this issue Mar 28, 2017 · 0 comments
Labels
cli Issues and PRs related to the Node.js command line interface. openssl Issues and PRs related to the OpenSSL dependency.

Comments

@jasnell
Copy link
Member

jasnell commented Mar 28, 2017

The --use-bundled-ca and --use-openssl-ca command line arguments are mutually exclusive but can both be used on the same command line. The behavior depends on the order in which they are used.

// Uses openssl-ca

$ node --use-bundled-ca --use-openssl-ca

// Uses bundled-ca

$ node --use-openssl-ca --use-bundled-ca

Since the options are mutually exclusive, it would likely be better to abort if both are used.

  • Version:
  • Platform:
  • Subsystem:
@mscdex mscdex added cli Issues and PRs related to the Node.js command line interface. openssl Issues and PRs related to the OpenSSL dependency. labels Mar 28, 2017
@danbev danbev mentioned this issue Mar 28, 2017
Closed
2 tasks
danbev added a commit to danbev/node that referenced this issue Mar 31, 2017
@danbev
src: add --use-bundled-ca --use-openssl-ca check
698f321 
The --use-bundled-ca and --use-openssl-ca command line arguments are
mutually exclusive but can both be used on the same command line.

This commit adds a check if both options are used.

Fixes: nodejs#12083
@danbev danbev closed this as completed in 8a7db9d Mar 31, 2017
danbev added a commit to danbev/node that referenced this issue May 30, 2017
@danbev
src: add --use-bundled-ca --use-openssl-ca check
2d4775a 
The --use-bundled-ca and --use-openssl-ca command line arguments are
mutually exclusive but can both be used on the same command line.

This commit adds a check if both options are used.

Fixes: nodejs#12083
PR-URL: nodejs#12087
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
danbev added a commit to danbev/node that referenced this issue Aug 15, 2017
@danbev
src: add --use-bundled-ca --use-openssl-ca check
a82aa9d 
The --use-bundled-ca and --use-openssl-ca command line arguments are
mutually exclusive but can both be used on the same command line.

This commit adds a check if both options are used.

Fixes: nodejs#12083
PR-URL: nodejs#12087
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@danbev danbev mentioned this issue Aug 15, 2017
Closed
2 tasks
danbev added a commit to danbev/node that referenced this issue Dec 20, 2017
@danbev
src: add --use-bundled-ca --use-openssl-ca check
c3f35be 
The --use-bundled-ca and --use-openssl-ca command line arguments are
mutually exclusive but can both be used on the same command line.

This commit adds a check if both options are used.

Fixes: nodejs#12083
PR-URL: nodejs#12087
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 17, 2018
@danbev @MylesBorins
src: add --use-bundled-ca --use-openssl-ca check
0d08e03 
The --use-bundled-ca and --use-openssl-ca command line arguments are
mutually exclusive but can both be used on the same command line.

This commit adds a check if both options are used.

Fixes: #12083
Backport-PR-URL: #17783
PR-URL: #12087
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 17, 2018
@danbev @MylesBorins
src: add --use-bundled-ca --use-openssl-ca check
dd2102d 
The --use-bundled-ca and --use-openssl-ca command line arguments are
mutually exclusive but can both be used on the same command line.

This commit adds a check if both options are used.

Fixes: #12083
Backport-PR-URL: #17783
PR-URL: #12087
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 11, 2018
@danbev @MylesBorins
src: add --use-bundled-ca --use-openssl-ca check
9ab8467 
The --use-bundled-ca and --use-openssl-ca command line arguments are
mutually exclusive but can both be used on the same command line.

This commit adds a check if both options are used.

Fixes: #12083
Backport-PR-URL: #17783
PR-URL: #12087
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 12, 2018
@danbev @MylesBorins
src: add --use-bundled-ca --use-openssl-ca check
6d291ef 
The --use-bundled-ca and --use-openssl-ca command line arguments are
mutually exclusive but can both be used on the same command line.

This commit adds a check if both options are used.

Fixes: #12083
Backport-PR-URL: #17783
PR-URL: #12087
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 13, 2018
@danbev @MylesBorins
src: add --use-bundled-ca --use-openssl-ca check
758dc81 
The --use-bundled-ca and --use-openssl-ca command line arguments are
mutually exclusive but can both be used on the same command line.

This commit adds a check if both options are used.

Fixes: #12083
Backport-PR-URL: #17783
PR-URL: #12087
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: add --use-bundled-ca --use-openssl-ca check danbev/node
2 participants
@mscdex @jasnell