tools,doc: fix version picker bug in html.js

The processing of strings like `8.x` into a major version number and a minor version number results in minor versions that are `NaN`. In that situation, since the picker will link to the latest docs in the major version, include the version in the version picker. Fixes: #23979 PR-URL: #24638 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
nodejs · Feb 11, 2019 · f9933ff · f9933ff
1 parent 7dee5e5
commit f9933ff
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/test/doctool/test-doctool-html.js b/test/doctool/test-doctool-html.js
@@ -95,6 +95,10 @@ const testData = [
     html: '<ol><li>fish</li><li>fish</li></ol>' +
       '<ul><li>Red fish</li><li>Blue fish</li></ul>',
   },
+  {
+    file: fixtures.path('altdocs.md'),
+    html: '<li><a href="https://nodejs.org/docs/latest-v8.x/api/foo.html">8.x',
+  },
 ];
 
 const spaces = /\s/g;
@@ -117,7 +121,8 @@ testData.forEach(({ file, html }) => {
         const actual = output.replace(spaces, '');
         // Assert that the input stripped of all whitespace contains the
         // expected markup.
-        assert(actual.includes(expected));
+        assert(actual.includes(expected),
+               `ACTUAL: ${actual}\nEXPECTED: ${expected}`);
       })
     );
   }));

diff --git a/test/fixtures/altdocs.md b/test/fixtures/altdocs.md
@@ -0,0 +1,2 @@
+# ALTDOCS
+<!--introduced_in=v8.4.0-->
diff --git a/tools/doc/html.js b/tools/doc/html.js
@@ -427,6 +427,7 @@ function altDocs(filename, docCreated) {
     const [versionMajor, versionMinor] = version.num.split('.').map(Number);
     if (docCreatedMajor > versionMajor) return false;
     if (docCreatedMajor < versionMajor) return true;
+    if (Number.isNaN(versionMinor)) return true;
     return docCreatedMinor <= versionMinor;
   }