lib: replace 'assert' with 'internal/assert' for many built-ins

Replace large 'assert' module with tiny 'internal/assert' module for
many built-in uses.

PR-URL: #25956
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>

lib/_http_client.js

@@ -24,7 +24,7 @@
 const util = require('util');
 const net = require('net');
 const url = require('url');
-const assert = require('assert').ok;
+const assert = require('internal/assert');
 const {
   _checkIsHttpToken: checkIsHttpToken,
   debug,

lib/_http_outgoing.js

@@ -21,7 +21,7 @@
 
 'use strict';
 
-const assert = require('assert').ok;
+const assert = require('internal/assert');
 const Stream = require('stream');
 const util = require('util');
 const internalUtil = require('internal/util');

lib/_http_server.js

@@ -23,7 +23,7 @@
 
 const util = require('util');
 const net = require('net');
-const assert = require('assert').ok;
+const assert = require('internal/assert');
 const {
   parsers,
   freeParser,

lib/_tls_wrap.js

@@ -23,7 +23,7 @@
 
 require('internal/util').assertCrypto();
 
-const assert = require('assert');
+const assert = require('internal/assert');
 const crypto = require('crypto');
 const net = require('net');
 const tls = require('tls');

lib/internal/child_process.js

@@ -19,7 +19,7 @@ const EventEmitter = require('events');
 const net = require('net');
 const dgram = require('dgram');
 const util = require('util');
-const assert = require('assert');
+const assert = require('internal/assert');
 
 const { Process } = internalBinding('process_wrap');
 const {

lib/internal/cluster/child.js

@@ -1,5 +1,5 @@
 'use strict';
-const assert = require('assert');
+const assert = require('internal/assert');
 const path = require('path');
 const EventEmitter = require('events');
 const { owner_symbol } = require('internal/async_hooks').symbols;

lib/internal/cluster/master.js

@@ -1,5 +1,5 @@
 'use strict';
-const assert = require('assert');
+const assert = require('internal/assert');
 const { fork } = require('child_process');
 const path = require('path');
 const EventEmitter = require('events');

lib/internal/cluster/shared_handle.js

@@ -1,5 +1,5 @@
 'use strict';
-const assert = require('assert');
+const assert = require('internal/assert');
 const dgram = require('internal/dgram');
 const net = require('net');
 

lib/internal/crypto/cipher.js

@@ -34,7 +34,7 @@ const {
   publicEncrypt: _publicEncrypt
 } = internalBinding('crypto');
 
-const assert = require('assert');
+const assert = require('internal/assert');
 const LazyTransform = require('internal/streams/lazy_transform');
 
 const { inherits } = require('util');

lib/internal/errors.js

@@ -208,7 +208,7 @@ function getMessage(key, args) {
   const msg = messages.get(key);
 
   if (util === undefined) util = require('util');
-  if (assert === undefined) assert = require('assert');
+  if (assert === undefined) assert = require('internal/assert');
 
   if (typeof msg === 'function') {
     assert(

lib/internal/fs/watchers.js

@@ -20,7 +20,7 @@ const { toNamespacedPath } = require('path');
 const { validateUint32 } = require('internal/validators');
 const { toPathIfFileURL } = require('internal/url');
 const util = require('util');
-const assert = require('assert');
+const assert = require('internal/assert');
 
 const kOldStatus = Symbol('kOldStatus');
 const kUseBigint = Symbol('kUseBigint');

lib/internal/http2/compat.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const assert = require('assert');
+const assert = require('internal/assert');
 const Stream = require('stream');
 const Readable = Stream.Readable;
 const binding = internalBinding('http2');

lib/internal/modules/cjs/loader.js

@@ -25,7 +25,7 @@ const { NativeModule } = require('internal/bootstrap/loaders');
 const { pathToFileURL } = require('internal/url');
 const util = require('util');
 const vm = require('vm');
-const assert = require('assert').ok;
+const assert = require('internal/assert');
 const fs = require('fs');
 const internalFS = require('internal/fs/utils');
 const path = require('path');

lib/internal/modules/esm/module_job.js

@@ -7,7 +7,7 @@ const {
 } = primordials;
 
 const { decorateErrorStack } = require('internal/util');
-const assert = require('assert');
+const assert = require('internal/assert');
 const resolvedPromise = SafePromise.resolve();
 
 function noop() {}

lib/internal/process/main_thread_only.js

@@ -153,7 +153,7 @@ function createSignalHandlers() {
 }
 
 function setupChildProcessIpcChannel() {
-  const assert = require('assert').strict;
+  const assert = require('internal/assert');
 
   const fd = parseInt(process.env.NODE_CHANNEL_FD, 10);
   assert(fd >= 0);

lib/internal/test/heap.js

@@ -5,7 +5,7 @@ process.emitWarning(
   'internal/test/heap');
 
 const { createHeapDump, buildEmbedderGraph } = internalBinding('heap_utils');
-const assert = require('assert');
+const assert = require('internal/assert');
 
 // This is not suitable for production code. It creates a full V8 heap dump,
 // parses it as JSON, and then creates complex objects from it, leading
@@ -44,9 +44,10 @@ function createJSHeapDump() {
     edgeIndex++;
   }
 
-  for (const node of nodes)
-    assert.strictEqual(node.edge_count, node.outgoingEdges.length);
-
+  for (const node of nodes) {
+    assert(node.edge_count === node.outgoingEdges.length,
+           `${node.edge_count} !== ${node.outgoingEdges.length}`);
+  }
   return nodes;
 }
 

lib/net.js

@@ -33,7 +33,7 @@ const {
   normalizedArgsSymbol,
   makeSyncWrite
 } = require('internal/net');
-const assert = require('assert');
+const assert = require('internal/assert');
 const {
   UV_EADDRINUSE,
   UV_EINVAL

lib/zlib.js

@@ -38,7 +38,7 @@ const {
   }
 } = require('util');
 const binding = internalBinding('zlib');
-const assert = require('assert').ok;
+const assert = require('internal/assert');
 const {
   Buffer,
   kMaxLength