Skip to content

Commit

Permalink
doc: clarify when not to run CI on docs
Browse files Browse the repository at this point in the history
Collaborators won't need to run CI on documentation-only changes.

PR-URL: #33101
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
  • Loading branch information
juanarbol authored and targos committed May 13, 2020
1 parent 7c8b0d2 commit f127ae3
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions doc/guides/collaborator-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,10 @@ All pull requests must pass continuous integration tests. Code changes must pass
on [project CI server](https://ci.nodejs.org/). Pull requests that only change
documentation and comments can use GitHub Actions results.

Do not land any pull requests without passing (green or yellow) CI runs. If
there are CI failures unrelated to the change in the pull request, try "Resume
Do not land any pull requests without a passing (green or yellow) CI run.
For documentation-only changes, GitHub Actions CI is sufficient.
For all other code changes, Jenkins CI must pass as well. If there are
Jenkins CI failures unrelated to the change in the pull request, try "Resume
Build". It is in the left navigation of the relevant `node-test-pull-request`
job. It will preserve all the green results from the current job but re-run
everything else. Start a fresh CI if more than seven days have elapsed since
Expand Down

0 comments on commit f127ae3

Please sign in to comment.