lib: replace charCodeAt with fixed Unicode

PR-URL: #32758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
nodejs · Jun 22, 2020 · ec01867 · ec01867
1 parent f151bde
commit ec01867
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 6 deletions.
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -42,13 +42,19 @@ const {
 const {
   isTypedArray, isSet, isMap, isSetIterator, isMapIterator,
 } = require('internal/util/types');
+const {
+  CHAR_LOWERCASE_B,
+  CHAR_LOWERCASE_E,
+  CHAR_LOWERCASE_N,
+  CHAR_UPPERCASE_C,
+} = require('internal/constants');
 const kCounts = Symbol('counts');
 
 const kTraceConsoleCategory = 'node,node.console';
-const kTraceCount = 'C'.charCodeAt(0);
-const kTraceBegin = 'b'.charCodeAt(0);
-const kTraceEnd = 'e'.charCodeAt(0);
-const kTraceInstant = 'n'.charCodeAt(0);
+const kTraceCount = CHAR_UPPERCASE_C;
+const kTraceBegin = CHAR_LOWERCASE_B;
+const kTraceEnd = CHAR_LOWERCASE_E;
+const kTraceInstant = CHAR_LOWERCASE_N;
 
 const kSecond = 1000;
 const kMinute = 60 * kSecond;

diff --git a/lib/internal/constants.js b/lib/internal/constants.js
@@ -8,6 +8,10 @@ module.exports = {
   CHAR_LOWERCASE_A: 97, /* a */
   CHAR_UPPERCASE_Z: 90, /* Z */
   CHAR_LOWERCASE_Z: 122, /* z */
+  CHAR_UPPERCASE_C: 67, /* C */
+  CHAR_LOWERCASE_B: 98, /* b */
+  CHAR_LOWERCASE_E: 101, /* e */
+  CHAR_LOWERCASE_N: 110, /* n */
 
   // Non-alphabetic chars.
   CHAR_DOT: 46, /* . */

diff --git a/lib/internal/trace_events_async_hooks.js b/lib/internal/trace_events_async_hooks.js
@@ -10,12 +10,16 @@ const {
 const { trace } = internalBinding('trace_events');
 const async_wrap = internalBinding('async_wrap');
 const async_hooks = require('async_hooks');
+const {
+  CHAR_LOWERCASE_B,
+  CHAR_LOWERCASE_E,
+} = require('internal/constants');
 
 // Use small letters such that chrome://tracing groups by the name.
 // The behavior is not only useful but the same as the events emitted using
 // the specific C++ macros.
-const kBeforeEvent = 'b'.charCodeAt(0);
-const kEndEvent = 'e'.charCodeAt(0);
+const kBeforeEvent = CHAR_LOWERCASE_B;
+const kEndEvent = CHAR_LOWERCASE_E;
 const kTraceEventCategory = 'node,node.async_hooks';
 
 const kEnabled = Symbol('enabled');