src: add default initializer in tls_wrap

PR-URL: #23567 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Oct 30, 2018 · db44a1a · db44a1a
1 parent ef2777d
commit db44a1a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/src/tls_wrap.cc b/src/tls_wrap.cc
@@ -59,13 +59,7 @@ TLSWrap::TLSWrap(Environment* env,
                 AsyncWrap::PROVIDER_TLSWRAP),
       SSLWrap<TLSWrap>(env, sc, kind),
       StreamBase(env),
-      sc_(sc),
-      write_size_(0),
-      started_(false),
-      established_(false),
-      shutdown_(false),
-      cycle_depth_(0),
-      eof_(false) {
+      sc_(sc) {
   MakeWeak();
 
   // sc comes from an Unwrap. Make sure it was assigned.

diff --git a/src/tls_wrap.h b/src/tls_wrap.h
@@ -149,19 +149,19 @@ class TLSWrap : public AsyncWrap,
   BIO* enc_in_ = nullptr;
   BIO* enc_out_ = nullptr;
   std::vector<uv_buf_t> pending_cleartext_input_;
-  size_t write_size_;
+  size_t write_size_ = 0;
   WriteWrap* current_write_ = nullptr;
   WriteWrap* current_empty_write_ = nullptr;
   bool write_callback_scheduled_ = false;
-  bool started_;
-  bool established_;
-  bool shutdown_;
+  bool started_ = false;
+  bool established_ = false;
+  bool shutdown_ = false;
   std::string error_;
-  int cycle_depth_;
+  int cycle_depth_ = 0;
 
   // If true - delivered EOF to the js-land, either after `close_notify`, or
   // after the `UV_EOF` on socket.
-  bool eof_;
+  bool eof_ = false;
 
  private:
   static void GetWriteQueueSize(