util: fix inspecting error with a throwing getter for cause

PR-URL: #47163 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
nodejs · Apr 8, 2023 · cbb3627 · cbb3627
1 parent 2192b5b
commit cbb3627
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 2 deletions.
diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -1243,9 +1243,16 @@ function getStackString(error) {
 function getStackFrames(ctx, err, stack) {
   const frames = StringPrototypeSplit(stack, '\n');
 
+  let cause;
+  try {
+    ({ cause } = err);
+  } catch {
+    // If 'cause' is a getter that throws, ignore it.
+  }
+
   // Remove stack frames identical to frames in cause.
-  if (err.cause && isError(err.cause)) {
-    const causeStack = getStackString(err.cause);
+  if (cause != null && isError(cause)) {
+    const causeStack = getStackString(cause);
     const causeStackStart = StringPrototypeIndexOf(causeStack, '\n    at');
     if (causeStackStart !== -1) {
       const causeFrames = StringPrototypeSplit(StringPrototypeSlice(causeStack, causeStackStart + 1), '\n');

diff --git a/test/message/util-inspect-error-cause.js b/test/message/util-inspect-error-cause.js
@@ -46,3 +46,9 @@ process.nextTick(() => {
   console.log(inspect(cause3));
   console.log(inspect(error2));
 });
+
+{
+  const error = new Error('cause that throws');
+  Reflect.defineProperty(error, 'cause', { get() { throw new Error(); } });
+  console.log(inspect(error));
+}
diff --git a/test/message/util-inspect-error-cause.out b/test/message/util-inspect-error-cause.out
@@ -33,6 +33,16 @@ Error: undefined cause
     at * {
   [cause]: undefined
 }
+Error: cause that throws
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
+    at * {
+  [cause]: [Getter]
+}
 RangeError: New Stack Frames
     at *
 *[90m    at *[39m {