Skip to content

Commit

Permalink
src: remove unnecessary call to SetHiddenPrototype
Browse files Browse the repository at this point in the history
Currently the template for the global object is explicitly marked as
hidden. This is unnecessary since the global object is automatically
marked as hidden by V8. Getting rid of this call gets rid of the last
use of SetHiddenPrototype.

PR-URL: #16554
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
  • Loading branch information
verwaest authored and fhinkel committed Nov 6, 2017
1 parent 8eef52e commit ba885c4
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/node_contextify.cc
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ class ContextifyContext {
EscapableHandleScope scope(env->isolate());
Local<FunctionTemplate> function_template =
FunctionTemplate::New(env->isolate());
function_template->SetHiddenPrototype(true);

function_template->SetClassName(sandbox_obj->GetConstructorName());

Expand Down

0 comments on commit ba885c4

Please sign in to comment.