http: do not use llhttp indexes for array

nodejs · Feb 12, 2024 · b7c9b5d · b7c9b5d
1 parent eff5939
commit b7c9b5d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/node_http_parser.cc b/src/node_http_parser.cc
@@ -1288,9 +1288,11 @@ void InitializeHttpParser(Local<Object> target,
          Integer::NewFromUnsigned(env->isolate(), kLenientAll));
 
   Local<Array> methods = Array::New(env->isolate());
+  size_t method_index = -1;
 #define V(num, name, string)                                                  \
     methods->Set(env->context(),                                              \
-        num, FIXED_ONE_BYTE_STRING(env->isolate(), #string)).Check();
+        ++method_index,                                                      \
+        FIXED_ONE_BYTE_STRING(env->isolate(), #string)).Check();
   HTTP_METHOD_MAP(V)
 #undef V
   target->Set(env->context(),

diff --git a/test/parallel/test-http-methods.js b/test/parallel/test-http-methods.js
@@ -52,6 +52,7 @@ const methods = [
   'PROPPATCH',
   'PURGE',
   'PUT',
+  'QUERY',
   'REBIND',
   'REPORT',
   'SEARCH',