src: default --icu_case_mapping on as a v8 option

* toLocaleUpperCase() and toLocaleLowerCase() do not function properly without this flag. * basic test case. The test case would fail if `--no_icu_case_mapping` was set. Fixes: #9445 PR-URL: #9454 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Nov 7, 2016 · b1ef638 · b1ef638
1 parent aac4af2
commit b1ef638
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -4191,6 +4191,14 @@ void Init(int* argc,
                             DispatchDebugMessagesAsyncCallback));
   uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));
 
+#if defined(NODE_HAVE_I18N_SUPPORT)
+  // Set the ICU casing flag early
+  // so the user can disable a flag --foo at run-time by passing
+  // --no_foo from the command line.
+  const char icu_case_mapping[] = "--icu_case_mapping";
+  V8::SetFlagsFromString(icu_case_mapping, sizeof(icu_case_mapping) - 1);
+#endif
+
 #if defined(NODE_V8_OPTIONS)
   // Should come before the call to V8::SetFlagsFromCommandLine()
   // so the user can disable a flag --foo at run-time by passing

diff --git a/test/parallel/test-intl.js b/test/parallel/test-intl.js
@@ -50,6 +50,11 @@ if (!common.hasIntl) {
     return;
   }
 
+  // Check casing
+  {
+    assert.strictEqual('I'.toLocaleLowerCase('tr'), 'ı');
+  }
+
   // Check with toLocaleString
   {
     const localeString = dtf.format(date0);