using symbol; added test

nodejs · Sep 3, 2023 · a119519 · a119519
1 parent 7d70385
commit a119519
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/repl.js b/lib/repl.js
@@ -204,6 +204,7 @@ const domainSet = new SafeWeakSet();
 
 const kBufferedCommandSymbol = Symbol('bufferedCommand');
 const kContextId = Symbol('contextId');
+const kLoadingSymbol = Symbol('loading');
 
 let addedNewListener = false;
 
@@ -882,7 +883,7 @@ function REPLServer(prompt,
       self[kBufferedCommandSymbol] += cmd + '\n';
 
       // code alignment
-      const matches = self._sawKeyPress && !self._loading ?
+      const matches = self._sawKeyPress && !self[kLoadingSymbol] ?
         RegExpPrototypeExec(/^\s+/, cmd) : null;
       if (matches) {
         const prefix = matches[0];
@@ -1801,10 +1802,10 @@ function defineDefaultCommands(repl) {
         const stats = fs.statSync(file);
         if (stats && stats.isFile()) {
           _turnOnEditorMode(this);
-          this._loading = true;
+          this[kLoadingSymbol] = true;
           const data = fs.readFileSync(file, 'utf8');
           this.write(data);
-          this._loading = false;
+          this[kLoadingSymbol] = false;
           _turnOffEditorMode(this);
           this.write('\n');
         } else {

diff --git a/test/parallel/test-repl-save-load.js b/test/parallel/test-repl-save-load.js
@@ -67,9 +67,14 @@ testMe.complete('inner.o', common.mustSucceed((data) => {
 // Clear the REPL.
 putIn.run(['.clear']);
 
+testMe._sawKeyPress = true;
 // Load the file back in.
 putIn.run([`.load ${saveFileName}`]);
 
+// Make sure loading doesn't insert extra indentation
+// https://github.com/nodejs/node/issues/47673
+assert.equal(testMe.line, '')
+
 // Make sure that the REPL data is "correct".
 testMe.complete('inner.o', common.mustSucceed((data) => {
   assert.deepStrictEqual(data, works);