perf_hooks: avoid memory leak on gc observer

Fixes: #22229 PR-URL: #22241 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: George Adams <[email protected]>
nodejs · Aug 15, 2018 · 9e41032 · 9e41032
1 parent 64c89d2
commit 9e41032
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/node_perf.cc b/src/node_perf.cc
@@ -272,6 +272,9 @@ void MarkGarbageCollectionEnd(Isolate* isolate,
                               v8::GCCallbackFlags flags,
                               void* data) {
   Environment* env = static_cast<Environment*>(data);
+  // If no one is listening to gc performance entries, do not create them.
+  if (!env->performance_state()->observers[NODE_PERFORMANCE_ENTRY_TYPE_GC])
+    return;
   GCPerformanceEntry* entry =
       new GCPerformanceEntry(env,
                              static_cast<PerformanceGCKind>(type),