util: fix width detection for DEL without ICU

This makes sure the DEL character (ASCII 127) is detected as a zero width character even if Node.js is not built with ICU. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33650 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Jun 27, 2020 · 987c927 · 987c927
1 parent 91d0d53
commit 987c927
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -2056,7 +2056,7 @@ if (internalBinding('config').hasIntl) {
 
   const isZeroWidthCodePoint = (code) => {
     return code <= 0x1F || // C0 control codes
-      (code > 0x7F && code <= 0x9F) || // C1 control codes
+      (code >= 0x7F && code <= 0x9F) || // C1 control codes
       (code >= 0x300 && code <= 0x36F) || // Combining Diacritical Marks
       (code >= 0x200B && code <= 0x200F) || // Modifying Invisible Characters
       // Combining Diacritical Marks for Symbols

diff --git a/test/parallel/test-icu-stringwidth.js b/test/parallel/test-icu-stringwidth.js
@@ -2,9 +2,6 @@
 'use strict';
 const common = require('../common');
 
-if (!common.hasIntl)
-  common.skip('missing Intl');
-
 const assert = require('assert');
 const { getStringWidth } = require('internal/util/inspect');
 
@@ -88,7 +85,7 @@ for (let i = 0; i < 256; i++) {
   }
 }
 
-{
+if (common.hasIntl) {
   const a = '한글'.normalize('NFD'); // 한글
   const b = '한글'.normalize('NFC'); // 한글
   assert.strictEqual(a.length, 6);