Skip to content

Commit

Permalink
child_process: update outdated comment
Browse files Browse the repository at this point in the history
PR-URL: #8988
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
tanujasawant authored and jasnell committed Oct 14, 2016
1 parent 31196ea commit 835fbee
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/child_process.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ exports.fork = function(modulePath /*, args, options*/) {
args = execArgv.concat([modulePath], args);

if (!Array.isArray(options.stdio)) {
// Leave stdin open for the IPC channel. stdout and stderr should be the
// same as the parent's if silent isn't set.
// Use a separate fd=3 for the IPC channel. Inherit stdin, stdout,
// and stderr from the parent if silent isn't set.
options.stdio = options.silent ? ['pipe', 'pipe', 'pipe', 'ipc'] :
[0, 1, 2, 'ipc'];
} else if (options.stdio.indexOf('ipc') === -1) {
Expand Down

1 comment on commit 835fbee

@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented on 835fbee Nov 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the / that accidentally found it into the PR-URL is breaking branch-diff 😢

and by breaking I mean not being regex'd

Please sign in to comment.