esm: use primordials

Converted uses of Object and Map to use frozen built in primordials. PR-URL: #26954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs · Mar 30, 2019 · 7a54709 · 7a54709
1 parent 6bc2ab1
commit 7a54709
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/lib/internal/modules/esm/default_resolve.js b/lib/internal/modules/esm/default_resolve.js
@@ -17,7 +17,12 @@ const { pathToFileURL, fileURLToPath } = require('internal/url');
 const { ERR_ENTRY_TYPE_MISMATCH,
         ERR_UNKNOWN_FILE_EXTENSION } = require('internal/errors').codes;
 
-const realpathCache = new Map();
+const {
+  Object,
+  SafeMap
+} = primordials;
+
+const realpathCache = new SafeMap();
 
 // const TYPE_NONE = 0;
 const TYPE_COMMONJS = 1;

diff --git a/lib/internal/modules/esm/loader.js b/lib/internal/modules/esm/loader.js
@@ -22,6 +22,11 @@ const FunctionBind = Function.call.bind(Function.prototype.bind);
 
 const debug = require('internal/util/debuglog').debuglog('esm');
 
+const {
+  Object,
+  SafeMap
+} = primordials;
+
 /* A Loader instance is used as the main entry point for loading ES modules.
  * Currently, this is a singleton -- there is only one used for loading
  * the main module and everything in its dependency graph. */
@@ -35,7 +40,7 @@ class Loader {
     this.moduleMap = new ModuleMap();
 
     // Map of already-loaded CJS modules to use
-    this.cjsCache = new Map();
+    this.cjsCache = new SafeMap();
 
     // The resolver has the signature
     //   (specifier : string, parentURL : string, defaultResolve)

diff --git a/lib/internal/modules/esm/translators.js b/lib/internal/modules/esm/translators.js
@@ -13,6 +13,7 @@ const createDynamicModule = require(
 const fs = require('fs');
 const {
   SafeMap,
+  JSON
 } = primordials;
 const { fileURLToPath, URL } = require('url');
 const { debuglog } = require('internal/util/debuglog');