Skip to content

Commit

Permalink
fixup! fixup! skip tests that are hopeless
Browse files Browse the repository at this point in the history
  • Loading branch information
aduh95 committed Sep 29, 2024
1 parent 9d35fca commit 78ec699
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions test/common/index.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const {
isDumbTerminal,
isFreeBSD,
isIBMi,
isInsideCWDWithUnusualChars,
isInsideDirWithUnusualChars,
isLinux,
isLinuxPPCBE,
isMainThread,
Expand Down Expand Up @@ -82,7 +82,7 @@ export {
isDumbTerminal,
isFreeBSD,
isIBMi,
isInsideCWDWithUnusualChars,
isInsideDirWithUnusualChars,
isLinux,
isLinuxPPCBE,
isMainThread,
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-cp.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ if (!isWindows && !isInsideDirWithUnusualChars) {
}

// It returns an error if attempt is made to copy socket.
if (!isWindows && !isInsideCWDWithUnusualChars) {
if (!isWindows && !isInsideDirWithUnusualChars) {
const src = nextdir();
mkdirSync(src);
const dest = nextdir();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-inspector-strip-types.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ async function runTest() {
return notification.params.url === scriptPath || notification.params.url === scriptURL.href;
});
// Verify that the script has a sourceURL, hinting that it is a generated source.
assert(scriptParsed.params.hasSourceURL || common.isInsideCWDWithUnusualChars);
assert(scriptParsed.params.hasSourceURL || common.isInsideDirWithUnusualChars);

await session.waitForPauseOnStart();
await session.runToCompletion();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-startup-empty-regexp-statics.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const common = require('../common');

if (common.isInsideCWDWithUnusualChars) {
if (common.isInsideDirWithUnusualChars) {
common.skip('expected failure');
}

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-startup-empty-regexp-statics.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import common from '../common/index.js';
import assert from 'node:assert';

if (!common.isInsideCWDWithUnusualChars) {
if (!common.isInsideDirWithUnusualChars) {
assert.strictEqual(RegExp.$_, '');
assert.strictEqual(RegExp.$0, undefined);
assert.strictEqual(RegExp.$1, '');
Expand Down

0 comments on commit 78ec699

Please sign in to comment.