src: use ToLocal in SafeGetenv

This commit replaces the IsEmpty call to use ToLocal instead which allows for the following ToLocalChecked function call to be avoided. PR-URL: #33695 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
nodejs · Jul 9, 2020 · 6f1d38c · 6f1d38c
1 parent 5b8cac8
commit 6f1d38c
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/node_credentials.cc b/src/node_credentials.cc
@@ -44,12 +44,13 @@ bool SafeGetenv(const char* key, std::string* text, Environment* env) {
   if (env != nullptr) {
     HandleScope handle_scope(env->isolate());
     TryCatch ignore_errors(env->isolate());
-    MaybeLocal<String> value = env->env_vars()->Get(
+    MaybeLocal<String> maybe_value = env->env_vars()->Get(
         env->isolate(),
         String::NewFromUtf8(env->isolate(), key, NewStringType::kNormal)
             .ToLocalChecked());
-    if (value.IsEmpty()) goto fail;
-    String::Utf8Value utf8_value(env->isolate(), value.ToLocalChecked());
+    Local<String> value;
+    if (!maybe_value.ToLocal(&value)) goto fail;
+    String::Utf8Value utf8_value(env->isolate(), value);
     if (*utf8_value == nullptr) goto fail;
     *text = std::string(*utf8_value, utf8_value.length());
     return true;