fixup! module: detect ESM syntax by trying to recompile as SourceText…

…Module
nodejs · Apr 12, 2024 · 6eec04e · 6eec04e
1 parent dc9f175
commit 6eec04e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/internal/modules/run_main.js b/lib/internal/modules/run_main.js
@@ -178,7 +178,7 @@ function executeUserEntryPoint(main = process.argv[1]) {
           const { shouldRetryAsESM } = internalBinding('contextify');
           const mainPath = resolvedMain || main;
           mainURL = pathToFileURL(mainPath).href;
-          retryAsESM = shouldRetryAsESM(error.message, cjsLoader.entryPointSource, mainPath);
+          retryAsESM = shouldRetryAsESM(error.message, cjsLoader.entryPointSource, mainURL);
           // In case the entry point is a large file, such as a bundle,
           // ensure no further references can prevent it being garbage-collected.
           cjsLoader.entryPointSource = undefined;

diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -1583,7 +1583,7 @@ static void ContainsModuleSyntax(const FunctionCallbackInfo<Value>& args) {
   CHECK(args[1]->IsString());
   Local<String> filename = args[1].As<String>();
 
-  // Argument 2: resource name (URL for module).
+  // Argument 2: resource name (URL for ES module).
   Local<String> resource_name = filename;
   if (args[2]->IsString()) {
     resource_name = args[2].As<String>();