test_runner: fix spec skip detection

nodejs · Apr 13, 2023 · 591847c · 591847c
1 parent 57508fb
commit 591847c
Show file tree

Hide file tree

Showing 5 changed files with 578 additions and 10 deletions.
diff --git a/lib/internal/test_runner/reporter/spec.js b/lib/internal/test_runner/reporter/spec.js
@@ -100,7 +100,7 @@ class SpecReporter extends Transform {
       ArrayPrototypeShift(this.#reported);
       hasChildren = true;
     }
-    const skippedSubtest = subtest && data.skip && data.skip !== undefined;
+    const skippedSubtest = subtest && 'skip' in data;
     const indent = this.#indent(data.nesting);
     return `${this.#formatTestReport(type, data, prefix, indent, hasChildren, skippedSubtest)}\n`;
   }

diff --git a/test/fixtures/test-runner/output/spec_reporter.snapshot b/test/fixtures/test-runner/output/spec_reporter.snapshot
@@ -150,7 +150,7 @@
  test with a name and options provided (*ms) # SKIP
  functionAndOptions (*ms) # SKIP
  escaped description \ # \#\ 
- 	     (*ms)
+ 	     (*ms)
  escaped skip message (*ms) # SKIP
  escaped todo message (*ms)
  escaped diagnostic (*ms)

diff --git a/test/fixtures/test-runner/output/spec_reporter_cli.js b/test/fixtures/test-runner/output/spec_reporter_cli.js
@@ -0,0 +1,12 @@
+// Flags: --no-warnings
+'use strict';
+require('../../../common');
+const fixtures = require('../../../common/fixtures');
+const spawn = require('node:child_process').spawn;
+
+const child = spawn(process.execPath,
+                    ['--no-warnings', '--test', '--test-reporter', 'spec', fixtures.path('test-runner/output/output.js')],
+                    { stdio: 'pipe' });
+// eslint-disable-next-line no-control-regex
+child.stdout.on('data', (d) => process.stdout.write(d.toString().replace(/[^\x00-\x7F]/g, '').replace(/\u001b\[\d+m/g, '')));
+child.stderr.pipe(process.stderr);