lib: reduce url getters on makeRequireFunction

PR-URL: #48492 Refs: nodejs/performance#92 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jun 24, 2023 · 578ffe1 · 578ffe1
1 parent 9b61322
commit 578ffe1
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/lib/internal/modules/helpers.js b/lib/internal/modules/helpers.js
@@ -86,20 +86,18 @@ function makeRequireFunction(mod, redirects) {
       if (destination === true) {
         missing = false;
       } else if (destination) {
-        const href = destination.href;
-        if (destination.protocol === 'node:') {
+        const { href, protocol } = destination;
+        if (protocol === 'node:') {
           const specifier = destination.pathname;
 
           if (BuiltinModule.canBeRequiredByUsers(specifier)) {
             const mod = loadBuiltinModule(specifier, href);
             return mod.exports;
           }
           throw new ERR_UNKNOWN_BUILTIN_MODULE(specifier);
-        } else if (destination.protocol === 'file:') {
-          let filepath;
-          if (urlToFileCache.has(href)) {
-            filepath = urlToFileCache.get(href);
-          } else {
+        } else if (protocol === 'file:') {
+          let filepath = urlToFileCache.get(href);
+          if (!filepath) {
             filepath = fileURLToPath(destination);
             urlToFileCache.set(href, filepath);
           }