events: fix event-target enumerable keys

PR-URL: #33616 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Jun 30, 2020 · 4b7ffa5 · 4b7ffa5
1 parent 2006d60
commit 4b7ffa5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -51,6 +51,13 @@ class Event {
     this.#bubbles = !!bubbles;
     this.#composed = !!composed;
     this.#type = String(type);
+    // isTrusted is special (LegacyUnforgeable)
+    Object.defineProperty(this, 'isTrusted', {
+      get() { return false; },
+      set(ignoredValue) { return false; },
+      enumerable: true,
+      configurable: false
+    });
   }
 
   [customInspectSymbol](depth, options) {
@@ -99,7 +106,6 @@ class Event {
   get returnValue() { return !this.defaultPrevented; }
   get bubbles() { return this.#bubbles; }
   get composed() { return this.#composed; }
-  get isTrusted() { return false; }
   get eventPhase() {
     return this[kTarget] ? 2 : 0;  // Equivalent to AT_TARGET or NONE
   }

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -50,7 +50,10 @@ ok(EventTarget);
   ev.preventDefault();
   strictEqual(ev.defaultPrevented, true);
 }
-
+{
+  const ev = new Event('foo');
+  deepStrictEqual(Object.keys(ev), ['isTrusted']);
+}
 {
   const eventTarget = new EventTarget();