inspector: do not prompt to use localhost

There are multiple reports of Windows7 not being able to resolve localhost on some setups (web search also confirms that). This change will advertise "127.0.0.1" as inspector host name. Fixes: #9382 Fixes: #9188 PR-URL: #9451 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Nov 7, 2016 · 173b088 · 173b088
1 parent 0325339
commit 173b088
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -39,7 +39,7 @@ static const uint8_t PROTOCOL_JSON[] = {
 
 std::string GetWsUrl(int port, const std::string& id) {
   char buf[1024];
-  snprintf(buf, sizeof(buf), "localhost:%d/%s", port, id.c_str());
+  snprintf(buf, sizeof(buf), "127.0.0.1:%d/%s", port, id.c_str());
   return buf;
 }
 

diff --git a/test/inspector/test-inspector.js b/test/inspector/test-inspector.js
@@ -11,7 +11,7 @@ function checkListResponse(err, response) {
   assert.ok(response[0]['devtoolsFrontendUrl']);
   assert.ok(
     response[0]['webSocketDebuggerUrl']
-      .match(/ws:\/\/localhost:\d+\/[0-9A-Fa-f]{8}-/));
+      .match(/ws:\/\/127.0.0.1:\d+\/[0-9A-Fa-f]{8}-/));
 }
 
 function checkVersion(err, response) {