Skip to content

Commit

Permalink
test:replace common.fixturesDir with commonfixtures
Browse files Browse the repository at this point in the history
PR-URL: #15832
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
feons authored and gireeshpunathil committed Oct 11, 2017
1 parent 20f8a22 commit 03550a5
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/parallel/test-tls-net-connect-prefer-path.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');

// This tests that both tls and net will ignore host and port if path is
// provided.
Expand Down Expand Up @@ -28,8 +29,8 @@ function mkServer(lib, tcp, cb) {
const args = [handler];
if (lib === tls) {
args.unshift({
cert: fs.readFileSync(`${common.fixturesDir}/test_cert.pem`),
key: fs.readFileSync(`${common.fixturesDir}/test_key.pem`)
cert: fixtures.readSync('test_cert.pem'),
key: fixtures.readSync('test_key.pem')
});
}
const server = lib.createServer(...args);
Expand Down

1 comment on commit 03550a5

@Trott
Copy link
Member

@Trott Trott commented on 03550a5 Oct 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gireeshpunathil First line of commit message is longer than 50 chars here. (I know a lot of people think that rule shouldn't even exist. This is a totally minor thing. Only noting it because core-validate-commit complains.)

On another note: THANKS FOR LANDING THIS CODE + LEARN PRs!!!!

Please sign in to comment.