crypto: fixup randomFill size and offset handling

Signed-off-by: James M Snell <[email protected]>
nodejs · Apr 7, 2021 · 023bb27 · 023bb27
1 parent 24fd791
commit 023bb27
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/internal/crypto/random.js b/lib/internal/crypto/random.js
@@ -155,10 +155,10 @@ function randomFill(buf, offset, size, callback) {
   if (typeof offset === 'function') {
     callback = offset;
     offset = 0;
-    size = buf.bytesLength;
+    size = buf.length;
   } else if (typeof size === 'function') {
     callback = size;
-    size = buf.byteLength - offset;
+    size = buf.length - offset;
   } else {
     validateCallback(callback);
   }
@@ -176,7 +176,6 @@ function randomFill(buf, offset, size, callback) {
     return;
   }
 
-  // TODO(@jasnell): This is not yet handling byte offsets right
   const job = new RandomBytesJob(
     kCryptoJobAsync,
     buf,

diff --git a/test/parallel/test-crypto-random.js b/test/parallel/test-crypto-random.js
@@ -525,3 +525,10 @@ assert.throws(
     assert.throws(() => crypto.randomInt(0, 1, i), cbError);
   });
 }
+
+{
+  // Verify that it doesn't throw or abort
+  crypto.randomFill(new Uint16Array(10), 0, common.mustSucceed());
+  crypto.randomFill(new Uint32Array(10), 0, common.mustSucceed());
+  crypto.randomFill(new Uint32Array(10), 0, 1, common.mustSucceed());
+}