Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add linter on gyp back #3101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add linter on gyp back #3101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,23 @@ jobs:
steps:
- uses: actions/checkout@v4
- run: pip install --user ruff
# Excluding `/gyp` directory as it is been checked in https://github.com/nodejs/gyp-next/ already
# `/gyp` directory is run in the next job.
- run: ruff check --output-format=github --extend-exclude=gyp --select="E,F,PLC,PLE,UP,W,YTT" --ignore="E721,PLC1901,S101,UP031" --target-version=py38 .

lint-gyp:
name: Lint Gyp
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install dependencies
working-directory: ./gyp
run: |
python -m pip install --upgrade pip setuptools
pip install --editable ".[dev]"
- name: Lint with ruff # See gyp/pyproject.toml for settings
working-directory: ./gyp
run: ruff check --output-format=github .

lint-js:
name: Lint JS
runs-on: ubuntu-latest
Expand Down
Loading