feat(gyp): update gyp to v0.16.1 #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2023
rzhao271
approved these changes
Oct 27, 2023
cclauss
approved these changes
Oct 27, 2023
cclauss
approved these changes
Oct 27, 2023
cclauss
reviewed
Oct 27, 2023
lukekarrys
approved these changes
Oct 27, 2023
lukekarrys
pushed a commit
that referenced
this pull request
Dec 2, 2024
* feat(gyp): update gyp to v0.15.1 * Add Python 3.12 to tests * Try to fix CI * Try specifying msvs-version * Modify the visual-studio matrix * Fix pythonLocation var * Fix Python tests * Get path * polish * feat(gyp): update gyp to v0.16.0 * feat(gyp): update gyp to v0.16.1 * CI: Don't install Python 'packaging' module (vendored in 'gyp-next' now) * Apply suggestions from code review * Upgrade to actions/checkout@v4 --------- Co-authored-by: Raymond Zhao <[email protected]> Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Bump
gyp-nextto v0.16.1. (nodejs/gyp-next@v0.14.0...v0.16.1)The biggest reason for bumping to newer
gyp-nextat the moment is for Python 3.12 support, in my opinion.Refs
PRs:
Resolves: #2912
Resolves: #2909
Resolves: #2825
Issues:
Resolves: #2915
Resolves: #2869
Credit
Most of this work was done by others. I based this PR's branch off of @rzhao271's branch for the gyp-next v0.15.1 PR #2909. See the gyp-next repo for the various contributors over there.
Reviewers?
Pinging previously active folks around this gyp-next bump, who are probably waiting for this to PR be posted: @rzhao271, @cclauss, @lukekarrys