Sync deps and engines with npm

[lukekarrys]

Checklist

• npm install && npm test passes
• commit message follows commit guidelines

Description of change

The main purpose of this PR is to update dependencies in order to dedupe as many deps as possible within npm. As can be seen in the npm/cli source there are a number of dependencies that end up nested within node-gyp/node_modules due to conflicting versions.

To accomplish this a number of other changes were made:

• fe5b13a BREAKING CHANGE update engines.node to ^14.17.0 || ^16.13.0 || >=18.0.0
• a729c15 Update standard to work with newer JS syntax and fix new lint errors
• 9ccc66d The @npm/cli-team team will be deprecating npmlog soon, so this PR drops that dependency in favor of proc-log + an otherwise dependency-less custom logger that includes the subset of functionality from npmlog used by node-gyp
• d485f1b Promisifies the build command since [email protected] is promise only
• 02fc75d Promisifies the remove and clean commands after dropping rimraf in favor of native recursive rm with fs.promises.rm

Commits

Each commit in the PR is a separate unit of work and I'd be happy to break it up if this is too difficult to review as is.

Reference issues/PRs

After doing the above, I looked through the list of open issues and PRs and identified the following that would either be closed or superseded by this PR.

Closes #2753
Closes #2647
Closes #2358
Closes #2357
Closes #2756
Closes #2379
Closes #2225

BEGIN_COMMIT_OVERRIDE
feat!: update engines.node to ^14.17.0 || ^16.13.0 || >=18.0.0
deps: nopt@^7.0.0
feat: replace npmlog with proc-log
deps: [email protected] and fix linting errors
deps: [email protected]
fix: promisify build command
deps: [email protected]
feat: drop rimraf dependency
fix: use fs/promises in favor of fs.promises
END_COMMIT_OVERRIDE

[lukekarrys]

#2772 addresses the test failures which are unrelated to the changes in this PR

[lukekarrys]

Also if this PR gets accepted, my other PR (#2771) should be reviewed first as I'd want it to make it into the node-gyp@9 release.

[lukekarrys]

@nodejs/node-gyp friendly ping to review this if possible. there's no timeframe, but this refactor will eliminate all non-deduped dependencies within npm, so it's a change we're excited to ship

[lukekarrys]

Rebased against main to resolve conflicts.

[rvagg]

ooof, this is a big changeset, which makes it hard to review; I suspect you're going to have to be very patient trying to get someone to review this, I certainly don't have time to look at this in the immediate future unfortunately. Nice to see all of this done, but doing it all in one go means that the chances of getting it in in a decent timeframe are quite low.

[lukekarrys]

@rvagg i appreciate the comment and agree that the size of the diff is very big.

i can break it up into multiple PRs and will consider the best way to do that in order to make reviewing easier. if you have any thoughts on what you would like to see there, please let me know.

off the top of my head and i could do the dev deps and linting separately since those changes are 90% automated. and the biggest functional difference is the logging which i could break out as well.

the biggest sticking point is that some of the PRs will need to be stacked since for example the logging change can’t be linked with the current version of standard. but if i go that route, i’ll make it clear in what order they should be reviewed.

[ruyadorno]

Also if it helps you @rvagg I actually took the time to review the changes and it all looks good to me. While I'm not an owner in this repo, hopefully having another collaborator pair of eyes might help.

[lukekarrys]

i'll also add that the commits are ordered and separated very closely to how i would separate them into different PRs, and the ones i linked in the body are the most relevant to a reviewer. but i understand that the github ui leaves something to be desired when reviewing individual commits within a PR

[imatlopez]

@rvagg plans for this? Happy it takes over my promisify prs

[KoenDG]

Sorry to suddenly interrupt, but this PR seems stuck, and a security update here depends on it: #2796 (comment)

Reading lerna/lerna#3605 indicates waiting for review, but scrolling up a but shows code comments that make it look like this review has already happened.

Is github not showing everything?

Regardless, what would be required for this to progress? I'm asking because it's related to a security issue, which if I'm reading it right cannot be resolved until this PR is finished and merged: https://nvd.nist.gov/vuln/detail/CVE-2022-25881

Apologies if this comes off strong, it's not my intent. It's just something I noticed a while back and it seems there's no movement. Thought I'd shake the grapevine a bit. Is there someone who needs to get involved in this that has perhaps lost track of it? It happens.

[rvagg]

Hey @imatlopez are you able to help review this? It really needs someone with the time and experience with this codebase to walk through it and give it the 👍. I'm unlikely to be able to find any time to do this but on the surface it seems like a worthwhile set of changes, just too much.

[rvagg]

I should acknowledge that @ruyadorno also walked through this, that's helpful. It would be good if we had more than one person who's name's familiar around here to give this a tick. This code goes out to a lot of people so we can't ship big changes lightly.

[imatlopez]

@lukekarrys you have conflicts in the pr, @rvagg gave it another pass today and besides those two comment, it looked ok to me.

[lukekarrys]

I will resolve the conflicts and address the comments this week.

[lukekarrys]

This PR has been rebased to fix conflicts with the latest commits in main. Since make-fetch-happen was updated in #2796, I dropped the commit updating that from this PR.

[JamesHenry]

Thanks for all your work on this @lukekarrys!

Looking forward to this landing!

[imatlopez]

@lukekarrys seems this has new conflicts @rvagg once those are resolved is merge on the table?

[lukekarrys]

Thanks for the heads up @imatlopez! I rebased this PR to fix all the conflicts. Note that the original body of the PR is also updated with the latest commit links.

The only real change to fix the conflicts was to drop the commit updating tap since this uses mocha now as a test runner.

[imatlopez]

I'd imagine tap would be preferred now that it comes with node but long live mocha?

2 windows tests are failing (but not all so flaky?)

[cclauss]

Re-running the two failed visual studio jobs.

[JamesHenry]

@cclauss Thanks a lot for rerunning, looks like this is good to go now?

(This issue indirectly causes a warning on every fresh lerna repo, that's why I'm particularly invested in its outcome 😄)

[cclauss]

@JamesHenry , @KoenDG Please Review changes at https://github.com/nodejs/node-gyp/pull/2770/files

[JamesHenry]

@cclauss I'm not part of the nodejs org, nor remotely familiar with this codebase, so I don't think my review carries much weight here! I'm just happy to see a resolution and if @lukekarrys is happy with it that's good enough for me

[lukekarrys]

The plan is to release this as v10.0.0 sometime in the next couple weeks. Thanks for your patience @JamesHenry.