Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: warn about SuppressDestruct() #926

Merged
merged 3 commits into from
Mar 17, 2021
Merged

doc: warn about SuppressDestruct() #926

merged 3 commits into from
Mar 17, 2021

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 9, 2021

Not sure how this ever made its way into the API, but people should never use this.

addaleax added 3 commits March 9, 2021 13:06
Not sure how this ever made its way into the API, but people should *never* use this.
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These suggestions/warning make sense given there is now support for worker threads.

@NickNaso NickNaso added the doc label Mar 16, 2021
@addaleax addaleax merged commit 87b7aae into main Mar 17, 2021
@addaleax addaleax deleted the addaleax-patch-1 branch March 17, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants