Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix error detection #914

Merged
merged 1 commit into from
Feb 23, 2021
Merged

tools: fix error detection #914

merged 1 commit into from
Feb 23, 2021

Conversation

RaisinTen
Copy link
Contributor

The ChildProces object result does not have an error property. We
should use stderr instead.

@RaisinTen
tools: fix error detection
40e3148 
The `ChildProces` object `result` does not have an `error` property. We
should use `stderr` instead.
@RaisinTen RaisinTen mentioned this pull request Feb 23, 2021
Closed
mhdawson
mhdawson approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 12c548b into nodejs:main Feb 23, 2021
@RaisinTen RaisinTen deleted the tools-fix-error-detection branch February 24, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaisinTen @mhdawson