src: fix leak in ObjectWrap instance set/getters #899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdawson
approved these changes
Feb 3, 2021
|
Flakey tests cause the run failure maybe @mhdawson ? |
|
@KevinEady it is a bit worrying that we seem to get intermittent failures. We saw that for a while in the CI but then it went away without me being able to figure out the cause. Might be worth running a few times locally (say 10 times) to make sure it does not recreate. |
mhdawson
pushed a commit
that referenced
this pull request
Feb 12, 2021
Fixes: #891 PR-URL: #899 Fixes: #891 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed as: a575a6e |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Fixes: nodejs/node-addon-api#891 PR-URL: nodejs/node-addon-api#899 Fixes: nodejs/node-addon-api#891 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Fixes: nodejs/node-addon-api#891 PR-URL: nodejs/node-addon-api#899 Fixes: nodejs/node-addon-api#891 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Fixes: nodejs/node-addon-api#891 PR-URL: nodejs/node-addon-api#899 Fixes: nodejs/node-addon-api#891 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Fixes: nodejs/node-addon-api#891 PR-URL: nodejs/node-addon-api#899 Fixes: nodejs/node-addon-api#891 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #891