test: remove outdated V8 flag #895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--concurrent-array-buffer-freeing` flag is going to be removed upstream in V8 9.0. Refs: v8/v8@0a480c3
|
cc @mhdawson could you please take a look once you are free? :) |
mhdawson
reviewed
Feb 2, 2021
| @@ -4,7 +4,7 @@ const majorNodeVersion = process.versions.node.split('.')[0]; | |||
|
|
|||
| if (typeof global.gc !== 'function') { | |||
| // Construct the correct (version-dependent) command-line args. | |||
| let args = ['--expose-gc', '--no-concurrent-array-buffer-freeing']; | |||
| let args = ['--expose-gc']; | |||
There was a problem hiding this comment.
Did you check the history of why this was added in the first place. I'm wondering if adding it needs to be Node.js version dependent versus just removing completely (ie might results in failures on older Node.js versions...)
There was a problem hiding this comment.
There was a problem hiding this comment.
I added a check to conditionally add the option if v8 has a major version that is less than 9. PTAL.
mhdawson
pushed a commit
that referenced
this pull request
Feb 12, 2021
The `--concurrent-array-buffer-freeing` flag is going to be removed upstream in V8 9.0. PR-URL: #895 Refs: v8/v8@0a480c3 Reviewed-By: Michael Dawson <[email protected]>
|
Landed as f7ed249 thanks @RaisinTen |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
The `--concurrent-array-buffer-freeing` flag is going to be removed upstream in V8 9.0. PR-URL: nodejs/node-addon-api#895 Refs: v8/v8@0a480c3 Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
The `--concurrent-array-buffer-freeing` flag is going to be removed upstream in V8 9.0. PR-URL: nodejs/node-addon-api#895 Refs: v8/v8@0a480c3 Reviewed-By: Michael Dawson <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
The `--concurrent-array-buffer-freeing` flag is going to be removed upstream in V8 9.0. PR-URL: nodejs/node-addon-api#895 Refs: v8/v8@0a480c3 Reviewed-By: Michael Dawson <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
The `--concurrent-array-buffer-freeing` flag is going to be removed upstream in V8 9.0. PR-URL: nodejs/node-addon-api#895 Refs: v8/v8@0a480c3 Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--concurrent-array-buffer-freeingflag is going to be removedupstream in V8 9.0.
Refs: v8/v8@0a480c3