test: added test case to check the addon building process. #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate use of `include` in an gyp array context, which happens to work when paths are absolute, but can fail on Windows when paths are relative and a gyp file contains multiple entries in its `include_dirs` directive. This change corrects documentation and tooling, adds support for relative paths (e.g. those containing whitespace) in a backwards compatible manner and makes the approach holistically consistent with that used by nan.
NickNaso
changed the title
6 tasks
|
@NickNaso there seem to be failures on 10.x for windows: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/2728/nodes=win-vs2017/ and it seems to fail with most platforms on 15.x -> https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/2727/ What is see when I try to run locally is: > node test
Testing with N-API Version '6'.
Starting test suite
Running test 'addon_build'
Error: Command failed: npm install
(node:105097) [DEP0139] DeprecationWarning: Calling process.umask() with no arguments is prone to race conditions and is a potential security vulnerability.
(Use `node --trace-deprecation ...` to show where the warning was created)
npm WARN npm npm does not support Node.js v15.0.0-pre
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8.
npm WARN npm You can find the latest version at https://nodejs.org/
npm ERR! cb.apply is not a function
npm ERR! A complete log of this run can be found in:
npm ERR! /home/mhdawson/.npm/_logs/2020-09-04T20_13_42_420Z-debug.log
at ChildProcess.exithandler (child_process.js:308:12)
at ChildProcess.emit (events.js:314:20)
at maybeClose (internal/child_process.js:1051:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5) {
killed: false,
code: 1,
signal: null,
cmd: 'npm install',
stdout: '',
stderr: '(node:105097) [DEP0139] DeprecationWarning: Calling process.umask() with no arguments is prone to race conditions and is a potential security vulnerability.\n' +
'(Use `node --trace-deprecation ...` to show where the warning was created)\n' +
'npm WARN npm npm does not support Node.js v15.0.0-pre\n' +
'npm WARN npm You should probably upgrade to a newer version of node as we\n' +
"npm WARN npm can't make any promises that npm will work with this version.\n" +
'npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8.\n' +
'npm WARN npm You can find the latest version at https://nodejs.org/\n' +
'npm ERR! cb.apply is not a function\n' +
'\n' +
'npm ERR! A complete log of this run can be found in:\n' +
'npm ERR! /home/mhdawson/.npm/_logs/2020-09-04T20_13_42_420Z-debug.log\n'
}
npm ERR! Test failed. See above for more details. |
|
CI: There is something to chnge for Node.js 15.x. |
|
CI: Now the test works fine on local machine for Node.js 15.x. I'm experimenting a problem on CI: I tried on my local machine on both |
|
@NickNaso thanks, I assume this is now ready to land ? |
|
@mhdawson Yes it's ready to be landed. Furthermore today I did another pass on the CI: |
mhdawson
pushed a commit
that referenced
this pull request
Sep 10, 2020
Refs: #766 PR-URL: #808 Reviewed-By: Michael Dawson <[email protected]>
|
Landed as 6562e6b |
Superlokkus
pushed a commit
to Superlokkus/node-addon-api
that referenced
this pull request
Nov 20, 2020
Refs: nodejs#766 PR-URL: nodejs#808 Reviewed-By: Michael Dawson <[email protected]>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Refs: nodejs/node-addon-api#766 PR-URL: nodejs/node-addon-api#808 Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Refs: nodejs/node-addon-api#766 PR-URL: nodejs/node-addon-api#808 Reviewed-By: Michael Dawson <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Refs: nodejs/node-addon-api#766 PR-URL: nodejs/node-addon-api#808 Reviewed-By: Michael Dawson <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Refs: nodejs/node-addon-api#766 PR-URL: nodejs/node-addon-api#808 Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complete the work done on PR #766.
The PR introduce some test to check to build of an addon.
Refs:
napi.hunable to find in Windows from v3.0.1 #769