-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fixed the execution for the threadsfafe function test. #807
Conversation
Can you add a bit more detail on what you saw in terms of it not running? When I run the tests before apply the patch I see:
|
Hi @mhdawson, module.exports = async function() {
console.log('Execution of test for threadsafe function');
await test(require(`../build/${buildType}/binding.node`));
await test(require(`../build/${buildType}/binding_noexcept.node`));
}; you could see that the test will not be executed. This happened in the PR #787. |
@NickNaso thanks for the clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test: fixed the execution for the threasfafe function test PR-URL: #807 Fixes: #806 Reviewed-By: Michael Dawson <[email protected]> -sh-4.2$
Landed as a13b36c |
test: fixed the execution for the threasfafe function test PR-URL: nodejs#807 Fixes: nodejs#806 Reviewed-By: Michael Dawson <[email protected]> -sh-4.2$
test: fixed the execution for the threasfafe function test PR-URL: nodejs/node-addon-api#807 Fixes: nodejs/node-addon-api#806 Reviewed-By: Michael Dawson <[email protected]> -sh-4.2$
test: fixed the execution for the threasfafe function test PR-URL: nodejs/node-addon-api#807 Fixes: nodejs/node-addon-api#806 Reviewed-By: Michael Dawson <[email protected]> -sh-4.2$
test: fixed the execution for the threasfafe function test PR-URL: nodejs/node-addon-api#807 Fixes: nodejs/node-addon-api#806 Reviewed-By: Michael Dawson <[email protected]> -sh-4.2$
test: fixed the execution for the threasfafe function test PR-URL: nodejs/node-addon-api#807 Fixes: nodejs/node-addon-api#806 Reviewed-By: Michael Dawson <[email protected]> -sh-4.2$
Fixes: #806