-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add instance data APIs #708
doc: add instance data APIs #708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think to use the complete namespace like we tried to do all over the rest fo the documentation? Es. Napi::Env::YOUR-METHOD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like GetInstanceData
doesn't get documented here?
@gabrielschulhof Do you have time to work on this PR? I need to insert this documentation on the new release. |
D'oh! I forgot |
Signed-off-by: Gabriel Schulhof <[email protected]> Re: nodejs#567 (comment)
22ee1d9
to
e2e2b84
Compare
@NickNaso @legendecas @mhdawson I added the docs for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Gabriel Schulhof <[email protected]> Re: #567 (comment) PR-URL: #708 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Landed in 381c0da. |
Signed-off-by: Gabriel Schulhof <[email protected]> Re: nodejs/node-addon-api#567 (comment) PR-URL: nodejs/node-addon-api#708 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]> Re: nodejs/node-addon-api#567 (comment) PR-URL: nodejs/node-addon-api#708 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]> Re: nodejs/node-addon-api#567 (comment) PR-URL: nodejs/node-addon-api#708 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]> Re: nodejs/node-addon-api#567 (comment) PR-URL: nodejs/node-addon-api#708 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
No description provided.