add test for own properties on ObjectWrap #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gms1
changed the title
gms1
commented
Jan 6, 2020
| Napi::PropertyDescriptor::Accessor(info.Env(), | ||
| info.This().As<Napi::Object>(), | ||
| "ownProperty", | ||
| OwnPropertyGetter, |
There was a problem hiding this comment.
worth considering:
- OwnPropertyGetter,
- napi_enumerable, this));
+ std::bind(&Test::Getter, this, std::placeholders::_1),
+ napi_enumerable));
gabrielschulhof
approved these changes
Jan 6, 2020
legendecas
approved these changes
Jan 7, 2020
|
@gms1 if you pull in @legendecas suggested change we can move forward in landing this. |
Co-Authored-By: legendecas <[email protected]>
|
CI:
|
gabrielschulhof
pushed a commit
that referenced
this pull request
Jan 10, 2020
PR-URL: #645 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in e8935bd. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
PR-URL: nodejs/node-addon-api#645 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs/node-addon-api#645 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
PR-URL: nodejs/node-addon-api#645 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#645 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #644