tsfn: Remove erroneous finalizer cleanup #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes leftover cleanup in finalizer that was part of the original TSFN implementation. Fixes: nodejs#632
|
This addresses leftover cleanup code from original implementation where |
|
Hi, just following up on the issue. Thanks for taking care of it! |
gabrielschulhof
approved these changes
Dec 24, 2019
gabrielschulhof
pushed a commit
that referenced
this pull request
Dec 25, 2019
Removes leftover cleanup in finalizer that was part of the original TSFN implementation. Fixes: #632 PR-URL: #636 Reviewed-By: Gabriel Schulhof <[email protected]>
|
Landed in 5eeabb0. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Removes leftover cleanup in finalizer that was part of the original TSFN implementation. Fixes: nodejs/node-addon-api#632 PR-URL: nodejs/node-addon-api#636 Reviewed-By: Gabriel Schulhof <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Removes leftover cleanup in finalizer that was part of the original TSFN implementation. Fixes: nodejs/node-addon-api#632 PR-URL: nodejs/node-addon-api#636 Reviewed-By: Gabriel Schulhof <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Removes leftover cleanup in finalizer that was part of the original TSFN implementation. Fixes: nodejs/node-addon-api#632 PR-URL: nodejs/node-addon-api#636 Reviewed-By: Gabriel Schulhof <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Removes leftover cleanup in finalizer that was part of the original TSFN implementation. Fixes: nodejs/node-addon-api#632 PR-URL: nodejs/node-addon-api#636 Reviewed-By: Gabriel Schulhof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes leftover cleanup in finalizer that was part of the original TSFN
implementation.
Fixes: #632