Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string.md: Document existing New(env, value, length) APIs #486

Merged
merged 1 commit into from
Jun 5, 2019
Merged

string.md: Document existing New(env, value, length) APIs #486

merged 1 commit into from
Jun 5, 2019

Conversation

tux3
Copy link
Contributor

@tux3 tux3 commented May 27, 2019

This is a drive-by PR to document the String::New functions that take non null-terminated strings.

mhdawson
mhdawson approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NickNaso
NickNaso approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit f633fbd into nodejs:master Jun 5, 2019
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
string.md: Document existing New(env, value, length) APIs
92104ab 
PR-URL: nodejs/node-addon-api#486
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
string.md: Document existing New(env, value, length) APIs
d8f9158 
PR-URL: nodejs/node-addon-api#486
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
string.md: Document existing New(env, value, length) APIs
8fb12e4 
PR-URL: nodejs/node-addon-api#486
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
string.md: Document existing New(env, value, length) APIs
16a1fa7 
PR-URL: nodejs/node-addon-api#486
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tux3 @NickNaso @mhdawson